From 797f1967ec109339020984d453749dc7d534e54c Mon Sep 17 00:00:00 2001
From: tsteven4 <13596209+tsteven4@users.noreply.github.com>
Date: Wed, 19 Jan 2022 12:23:27 -0700
Subject: [PATCH] finish killing GUI charset handling (#819)

* finish killing gui charset handling.

* more char set dead code cleaning

* even more dead code buried.
---
 gui/advui.ui      | 17 ++---------------
 gui/babeldata.h   |  3 ---
 gui/mainwindow.cc | 16 ----------------
 gui/mainwindow.h  |  5 -----
 4 files changed, 2 insertions(+), 39 deletions(-)

diff --git a/gui/advui.ui b/gui/advui.ui
index d1e031fc2..71494cc9a 100644
--- a/gui/advui.ui
+++ b/gui/advui.ui
@@ -6,8 +6,8 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>280</width>
-    <height>185</height>
+    <width>288</width>
+    <height>196</height>
    </rect>
   </property>
   <property name="windowTitle">
@@ -24,19 +24,6 @@
      </property>
     </widget>
    </item>
-   <item>
-    <widget class="QCheckBox" name="enableCharSetXform">
-     <property name="enabled">
-      <bool>true</bool>
-     </property>
-     <property name="toolTip">
-      <string>Convert character set encoding between input and output</string>
-     </property>
-     <property name="text">
-      <string>Enable character set transformation</string>
-     </property>
-    </widget>
-   </item>
    <item>
     <widget class="QCheckBox" name="previewGmap">
      <property name="text">
diff --git a/gui/babeldata.h b/gui/babeldata.h
index 198f88893..9adb4dcd5 100644
--- a/gui/babeldata.h
+++ b/gui/babeldata.h
@@ -50,7 +50,6 @@ public:
     outputCharSet_(QString()),
     synthShortNames_(false),
     forceGPSTypes_(false),
-    enableCharSetXform_(false),
     debugLevel_(-1),
     inputBrowse_(QString()),
     outputBrowse_(QString()),
@@ -106,7 +105,6 @@ public:
 
     sg.addVarSetting(new BoolSetting("app.synthShortNames", synthShortNames_));
     sg.addVarSetting(new BoolSetting("app.forceGPSTypes", forceGPSTypes_));
-    sg.addVarSetting(new BoolSetting("app.enableCharSetXform", enableCharSetXform_));
 
     sg.addVarSetting(new StringSetting("app.inputBrowse", inputBrowse_));
     sg.addVarSetting(new StringSetting("app.outputBrowse", outputBrowse_));
@@ -156,7 +154,6 @@ public:
 
   bool synthShortNames_;
   bool forceGPSTypes_;
-  bool enableCharSetXform_;
   int  debugLevel_;
 
   QString inputBrowse_, outputBrowse_;
diff --git a/gui/mainwindow.cc b/gui/mainwindow.cc
index c76fa7f9c..862629cfc 100644
--- a/gui/mainwindow.cc
+++ b/gui/mainwindow.cc
@@ -877,22 +877,6 @@ int MainWindow::formatIndexFromName(bool isFile, const QString& nm)
   return 0;
 }
 
-//------------------------------------------------------------------------
-QString MainWindow::charSetFromCombo(QComboBox* combo)
-{
-  int i = combo->itemData((combo->currentIndex())).toInt();
-  return (i >=0) ? charSets_[i] : QString();
-}
-
-//------------------------------------------------------------------------
-void MainWindow::setComboToCharSet(QComboBox* combo, const QString& cset)
-{
-  for (int i=0; i<charSets_.size(); i++) {
-    if (charSets_[i] == cset) {
-      combo->setCurrentIndex(i+1); // first index is default;
-    }
-  }
-}
 //------------------------------------------------------------------------
 void MainWindow::applyActionX()
 {
diff --git a/gui/mainwindow.h b/gui/mainwindow.h
index d899ff02c..78ba6ee32 100644
--- a/gui/mainwindow.h
+++ b/gui/mainwindow.h
@@ -61,7 +61,6 @@ private:
   QString        babelVersion_;
   bool		 isBeta_;
   QPixmap        lights_[4];
-  QStringList    charSets_;
   AllFiltersData filterData_;
   BabelData      babelData_;
   bool           fmtChgInterlock_;
@@ -100,10 +99,6 @@ private:
   void loadOutputDeviceNameCombo(const QString& format);
   bool formatSupportsUSB(const QString& format);
   bool formatSupportsSerial(const QString& format);
-  void loadCharSetCombos();
-  void checkCharSetCombos();
-  QString charSetFromCombo(QComboBox*);
-  void setComboToCharSet(QComboBox*, const QString&);
   void updateFilterStatus();
   void setWidgetValues();
   void getWidgetValues();
-- 
2.30.2